fix#74
Mainly borrowed from https://github.com/drone-plugins/drone-docker/tree/master/cmd/drone-ecr.
`drone/ecr` is still on 20.10.14 and sparsely updated/maintained. Would be great to add support for additional registries like ECR to buildx.
The login process is as follows:
1. Call the AWS API with some arguments to get a short-lived auth token (12h)
2. Use the token and Username `AWS` for the `docker login` call
## Notes
- To push to ECR, the full registry URL must be given in the tag, i.e. `registry/owner/repo`. For this, `Registry` must also be added the to `Build` struct besides the `Settings` struct
- For now I've only referenced the source in `ecr.go` by using the most recent commit of today. Should this be done differently?
- The implementation here from me is simple and probably a bit "naive" as this is my first "real" golang feature PR.
- I've tested this change with a custom image and was able to successfully push to ECR while dynamically creating a repository. Proper tests would still be great...
- Vars `assumeRole` and `externalID` are somehow not exposed in https://plugins.drone.io/plugins/ecr and I am not sure if this is by design or because they were just forgotten. Anyhow, this is reason I didn't expose them for now and just added internal dummy vars.
Co-authored-by: pat-s <patrick.schratz@gmail.com>
Co-committed-by: pat-s <patrick.schratz@gmail.com>
Current runs of the plugin output the following
```
WARNING: buildx: git was not found in the system. Current commit information was not captured by the build
```
adding `git` should solve this.
Co-authored-by: 6543 <6543@obermui.de>
Reviewed-on: https://codeberg.org/woodpecker-plugins/docker-buildx/pulls/109
Reviewed-by: 6543 <6543@obermui.de>
Co-authored-by: pat-s <patrick.schratz@gmail.com>
Co-committed-by: pat-s <patrick.schratz@gmail.com>
This fixes an error in the documentation. Multiple tags in tags_file are separated by a newline instead of a comma.
See: 5116f6263f/plugin/impl.go (L138)
Reviewed-on: https://codeberg.org/woodpecker-plugins/docker-buildx/pulls/107
Reviewed-by: Patrick Schratz <pat-s@noreply.codeberg.org>
Co-authored-by: Thomas Renes <thomas@renesweb.nl>
Co-committed-by: Thomas Renes <thomas@renesweb.nl>
#### 📖 Summary
Adds `--driver-opt` buildx arg as plugin parameter. This should make it possible to pass through proxy settings.
#### 📑 Test Plan
> 💡 Select your test plan for the code changes.
- [x] CI pipeline tests
- Custom test
- No test plan
##### Details / Justification
Manually tested on own instance behind corporate proxy:
Unfortunately the `--build-arg` passthru seems not working
#### 📚 Additional Notes
- fixes#82
- still to do:
- [x] update docs
- [x] add usage example
> 💡NOTE: This is my first contribution in this codebase. Feedback and help is probably needed 😸
Reviewed-on: https://codeberg.org/woodpecker-plugins/docker-buildx/pulls/93
Reviewed-by: Patrick Schratz <pat-s@noreply.codeberg.org>
Co-authored-by: OCram85 <marco.blessing@googlemail.com>
Co-committed-by: OCram85 <marco.blessing@googlemail.com>
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| docker | final | major | `20.10-dind` -> `24.0-dind` |
---
### Configuration
📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - "before 4am" (UTC).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMS4yIiwidXBkYXRlZEluVmVyIjoiMzcuMzEuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
Co-authored-by: woodpecker-bot <woodpecker-bot@codeberg.ci>
Reviewed-on: https://codeberg.org/woodpecker-plugins/docker-buildx/pulls/99
Co-authored-by: woodpecker-bot <woodpecker-bot@noreply.codeberg.org>
Co-committed-by: woodpecker-bot <woodpecker-bot@noreply.codeberg.org>
- Only the `.tags` filename is allowed.
- The file can have multiple tags, as a CSV
Reviewed-on: https://codeberg.org/woodpecker-plugins/docker-buildx/pulls/75
Reviewed-by: Patrick Schratz <pat-s@noreply.codeberg.org>
Co-authored-by: lonix <lonix@noreply.codeberg.org>
Co-committed-by: lonix <lonix@noreply.codeberg.org>
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| golang | | minor | `1.20` -> `1.21` |
| golang | stage | minor | `1.20` -> `1.21` |
---
### Configuration
📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 **Automerge**: Enabled.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNC4wIiwidXBkYXRlZEluVmVyIjoiMzcuMjQuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
Reviewed-on: https://codeberg.org/woodpecker-plugins/docker-buildx/pulls/89
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/joho/godotenv](https://github.com/joho/godotenv) | require | minor | `v1.4.0` -> `v1.5.1` |
> ❗ **Important**
>
> Release Notes retrieval for this PR were skipped because no github.com credentials were available.
> If you are self-hosted, please see [this instruction](https://github.com/renovatebot/renovate/blob/master/docs/usage/examples/self-hosting.md#githubcom-token-for-release-notes).
---
### Configuration
📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 **Automerge**: Enabled.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNi4wIiwidXBkYXRlZEluVmVyIjoiMzcuMjYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
Reviewed-on: https://codeberg.org/woodpecker-plugins/docker-buildx/pulls/90
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/urfave/cli/v2](https://github.com/urfave/cli) | require | minor | `v2.16.3` -> `v2.25.7` |
> ❗ **Important**
>
> Release Notes retrieval for this PR were skipped because no github.com credentials were available.
> If you are self-hosted, please see [this instruction](https://github.com/renovatebot/renovate/blob/master/docs/usage/examples/self-hosting.md#githubcom-token-for-release-notes).
---
### Configuration
📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 **Automerge**: Enabled.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNi4wIiwidXBkYXRlZEluVmVyIjoiMzcuMjYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
Reviewed-on: https://codeberg.org/woodpecker-plugins/docker-buildx/pulls/91
Co-authored-by: Patrick Schratz <pat-s@mailbox.org>
Co-committed-by: Patrick Schratz <pat-s@mailbox.org>
Port from https://github.com/thegeeklab/drone-docker-buildx/pull/124
Basically docker cache got a bit fancier and now includes a cache manifest. Manually pulling these containers isn't sufficient enough, so remove the manual pull.
cache_to allows you to push your cache including a manifest to a remote location: https://docs.docker.com/engine/reference/commandline/buildx_build/#cache-to
Unfortunately this option isn't quite that useful: to fully use this feature, you need to supply your arguments in CSV format, which woodpecker unhelpfully splits into multiple completely separate arguments, breaking it :(
With a further change to fix that issue I managed to turn a multistage rust build from ~3 minutes down to 20 seconds.
Co-authored-by: miniduikboot <mini@duikbo.at>
Reviewed-on: https://codeberg.org/woodpecker-plugins/plugin-docker-buildx/pulls/46
Reviewed-by: 6543 <6543@obermui.de>
Co-authored-by: miniduikboot <miniduikboot@noreply.codeberg.org>
Co-committed-by: miniduikboot <miniduikboot@noreply.codeberg.org>
