Commit graph

811 commits

Author SHA1 Message Date
joshua stein a812f25c2f Markdowner: use Nokogiri for html rewriting
brute forcing changes by regexps gets things wrong sometimes, so use
nokogiri to parse the html output of rdiscount and do changes on
individual nodes, then turn back into a string

we lose the ability to move punctuation inside of auto-generated
links, but i don't see any easy/definitive way to do this properly.

closes #242
closes #209
2015-12-07 12:27:03 -06:00
joshua stein abd662fc7e add some tests for Markdowner
including failing ones for bug #209 and bug #242
2015-12-03 15:17:31 -06:00
joshua stein 138c658052 cleanup tests
i am not going to waste any more time cleaning up these specs that
were written by other people to be so crafty that they break or spew
tons of garbage every time something is updated.
2015-12-03 15:03:23 -06:00
joshua stein 9f9e608fc8 fix fetched_attributes fallout 2015-12-03 14:57:33 -06:00
joshua stein 8b4dec5746 sync db schema 2015-12-03 14:57:11 -06:00
joshua stein 4e94bc9e29 Comment: for emailed comments, show that in the message id used for mailing list 2015-12-02 13:46:19 -06:00
joshua stein 5d8c7f7167 make time_ago_in_words_label use a custom time_ago_in_words
"36 hours ago" is more useful than "1 day ago", so tweak the times
used to jump to the next divisor
2015-12-02 13:46:19 -06:00
joshua stein c05f526a57 make story description icon a link to the story page, revert c1d1a44472
i don't like showing "discuss" to logged out users, and now that we
have a story description icon that can link to the story text, back
out the change that made logged out users see discuss when they
can't discuss it.
2015-12-02 13:46:19 -06:00
joshua stein 45b63935af Story: move fetched_* stuff into a single fetched_attributes 2015-12-02 13:46:19 -06:00
joshua stein c354485916 when a non-banned, deleted user logs in, reactivate their account 2015-11-18 12:08:45 -06:00
joshua stein 77e2000cb3 comment: put merge icon before avatar 2015-11-18 11:35:34 -06:00
joshua stein ee363e3635 filters: link to /tags 2015-11-13 15:53:38 -06:00
joshua stein 80311fa978 message view: fix double 'ago' 2015-11-13 15:53:22 -06:00
joshua stein 8edc8b926f css: all this time i had no idea we didn't have a white background 2015-11-13 15:53:06 -06:00
joshua stein 870d2b10fa Merge pull request #240 from apg/authored-by-or-via
Update byline for non-authored submissions.
2015-11-13 15:52:43 -06:00
Andrew Gwozdziewycz 760e2a3f36 Update by line for non-authored submissions.
- Use 'via' for credit instead of 'by', which implies creation.
2015-11-13 01:28:32 -08:00
joshua stein 97dac71389 tags: set @title
tweak @title of filters controller
2015-11-09 10:01:43 -06:00
joshua stein 09fd14dd93 add a tag cloud thingy
closes #236
2015-11-09 09:52:32 -06:00
joshua stein 4fb0e7deb5 Merge pull request #237 from stygstra/unconditional-comments
Show comments link even if there are no comments
2015-11-08 12:37:01 -06:00
David Stygstra c1d1a44472 Show comments link even if there are no comments
For stories with both text and a link that have no comments, the only
way to view the text is to either log in (no account :( ) or view the
page source and find the story ID. This commit fixes that by always
showing the comments link.
2015-11-08 12:23:52 -05:00
joshua stein e4a23f74ca change character for additional story text, add tip text 2015-11-06 08:56:28 -06:00
joshua stein 70a3b60f04 embolden story description character 2015-11-05 11:58:34 -06:00
joshua stein 6bebed996e make description present character an actual html entity
issue #227
2015-11-05 11:58:34 -06:00
joshua stein 9d79f2c76b include both urls in srcset, use 1x/2x instead of image width
seems to work better in firefox
2015-11-05 11:58:34 -06:00
joshua stein 72fc702abe Merge pull request #227 from pushcx/patch-1
Indicate if a story has a description
2015-11-05 11:50:15 -06:00
Peter Harkins f1f09face1 move before tags, use different symbol
Pilcrow is ugly. Alternates: *, †, ‡, §
2015-11-04 10:52:27 -06:00
joshua stein 1e6b892005 show hidpi images for avatars, site load icon, and favicon 2015-11-01 19:56:30 -06:00
joshua stein 37994c0306 story editing: consolidate auto tag application, add audio for soundcloud 2015-10-26 10:39:40 -05:00
joshua stein d4f375ce11 story submission bookmarklet: open to lobste.rs in a new tab 2015-10-24 18:25:07 -05:00
Peter Harkins d95619ce69 I meant markeddown_description 2015-10-20 07:57:50 -05:00
joshua stein 73342e7d45 settings: pushover has used subscriptions for a while, not a manual key 2015-10-19 19:13:34 -05:00
joshua stein 2ee262fe8a StoryCacher: cope with failed diffbot fetches 2015-10-19 19:13:15 -05:00
joshua stein d44d43e551 fix dup/clone confusion 2015-10-18 15:09:39 -05:00
joshua stein 77568760a2 don't show suggestion flash if user didn't do anything 2015-10-17 10:43:11 -05:00
joshua stein a337ee850e take suggestions on moderator stories, just not those with privileged tags
also allow moderators to make tag suggestions, we're people too
2015-10-17 10:38:48 -05:00
joshua stein 1d30378877 clone, not dup 2015-10-17 08:03:33 -05:00
joshua stein a4e3f04d2d Story: do automatic user suggestion promotion for story titles too
It's much less likely that users will all agree on an exact title
name, but try it anyway.
2015-10-16 18:28:57 -05:00
joshua stein 800aea1ca9 always show downvote summary if score is <= 0, else it's confusing
improves on 9c40023
2015-10-16 17:03:54 -05:00
joshua stein 14bf26f339 for story comments by author of story, color blue as well 2015-10-16 13:08:05 -05:00
joshua stein 3439b93b12 when editing a story, show suggested titles and tags 2015-10-15 10:23:25 -05:00
joshua stein e3c881b81a implement automatic tag changing in response to user suggestions
Right now it's just a simple check for SUGGESTION_QUORUM (currently
4) number of users agreeing on a set of new tags.

Log a moderation to the story submitter when this happens, and allow
moderations to be done by a non-specific user.

Issue #207
2015-10-15 10:04:23 -05:00
joshua stein 2ca2c94ef6 allow messages to come from system instead of a user 2015-10-15 10:01:42 -05:00
joshua stein 7974ab4090 don't take suggestions on moderator stories
This should probably only apply to stories with restricted tags,
though.
2015-10-15 09:38:26 -05:00
joshua stein 21927eccbe Story: always recalculate hotness after saving changes 2015-10-14 21:17:54 -05:00
joshua stein e940601a2f start on automated story title and tagging suggestions
Rather than keep "poorly titled" and "poorly tagged" as reasons for
flagging, make the user do the work of suggesting new ones.

At some point, suggested taggings will flip to real taggings once
they reach a certain count (to be determined later).  This also has
to take into account tagging sets that don't contain current tags,
for when they need to be removed.

For titles, I'm not yet sure how to handle this in an automated
fashion except for the (probably rare) case of multiple users
submitting the same exact thing, but at least collect them for now.

Issue #207
2015-10-14 20:32:24 -05:00
joshua stein 700c63b936 Story: extend MAX_EDIT_MINS to 3 hours 2015-10-14 18:23:06 -05:00
joshua stein 1c789fbae0 add /chat page 2015-10-11 13:04:16 -05:00
joshua stein 677da599f2 login: if user password hash is not at current rounds, re-encrypt it 2015-10-11 13:04:16 -05:00
joshua stein 80f7d5b095 remove or fix failing tests
Many of these fail because they were written with fancy rspec
features that don't work properly anymore and I don't care enough
about testing everything to update them.

See issue #228
2015-10-11 13:00:34 -05:00
joshua stein 696e669f60 mobile css: fix upvote/unvote/upvote still showing red arrow
closes #230
2015-10-10 20:36:48 -05:00