[Nostromo] Apply PHP Mess Detector recommendations

This commit is contained in:
Andrés Montañez 2017-01-10 22:02:35 -03:00
parent 2c567bebff
commit c2b83428f0
2 changed files with 9 additions and 9 deletions

View file

@ -144,15 +144,16 @@ class DeployCommand extends AbstractCommand
if (count($hosts) == 0) { if (count($hosts) == 0) {
$output->writeln(sprintf(' No hosts defined, skipping %s tasks', $this->getStageName())); $output->writeln(sprintf(' No hosts defined, skipping %s tasks', $this->getStageName()));
$output->writeln(''); $output->writeln('');
} else { return true;
foreach ($hosts as $host) { }
$this->runtime->setWorkingHost($host);
if (!$this->runTasks($output, $tasks)) { foreach ($hosts as $host) {
$this->runtime->setWorkingHost(null); $this->runtime->setWorkingHost($host);
throw $this->getException(); if (!$this->runTasks($output, $tasks)) {
}
$this->runtime->setWorkingHost(null); $this->runtime->setWorkingHost(null);
throw $this->getException();
} }
$this->runtime->setWorkingHost(null);
} }
} }

View file

@ -414,10 +414,9 @@ class Runtime
$host = $this->getWorkingHost(); $host = $this->getWorkingHost();
$sshConfig = $this->getSSHConfig(); $sshConfig = $this->getSSHConfig();
$cmdDelegate = $cmd;
if ($sudo === true) { if ($sudo === true) {
$cmdDelegate = sprintf('sudo %s', $cmd); $cmdDelegate = sprintf('sudo %s', $cmd);
} else {
$cmdDelegate = $cmd;
} }
if ($jail) { if ($jail) {