deblan/php-censor
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Fixed extra

Browse source
This commit is contained in:
Dmitry Khomutov 2017-02-19 01:21:46 +07:00
parent b83a6db697
commit 5d03a0ab35
No known key found for this signature in database
GPG key ID: 7EB36C9576F9ECB9
4 changed files with 3 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/PHPCensor/Model/Build.php
View file

@ -522,8 +522,6 @@ class Build extends Model
*/
public function setExtra($value)
{
$value = json_encode($value);
$this->validateString('Extra', $value);
if ($this->data['extra'] === $value) {

2
src/PHPCensor/Service/BuildService.php
View file

@ -87,7 +87,7 @@ class BuildService
}
if (!is_null($extra)) {
$build->setExtra($extra);
$build->setExtra(json_encode($extra));
}
$build = $this->buildStore->save($build);

2
tests/PHPCensor/Model/BuildTest.php
View file

@ -63,7 +63,7 @@ class BuildTest extends \PHPUnit_Framework_TestCase
];
$build = new Build();
$build->setExtra($info);
$build->setExtra(json_encode($info));
$this->assertEquals('Item One', $build->getExtra('item1'));
$this->assertEquals(2, $build->getExtra('item2'));

2
tests/PHPCensor/Service/BuildServiceTest.php
View file

@ -100,7 +100,7 @@ class BuildServiceTest extends \PHPUnit_Framework_TestCase
$build->setFinished(new \DateTime());
$build->setCommitMessage('test');
$build->setCommitterEmail('test@example.com');
$build->setExtra(['item1' => 1001]);
$build->setExtra(json_encode(['item1' => 1001]));
$returnValue = $this->testedService->createDuplicateBuild($build);