#19 Add the external web icon to the top menu when side_menu application is activated

Closed
opened 5 months ago by Ludovicis · 11 comments

Hello,
Thanks for your application.
Can you add the ability to add the external web icon to the top menu please, when your application is activated, please ?
Or add an option for that.

Thanks,

Bonjour,
Merci pour l’application.
Serait ce possible d’avoir les icones des sites web externe (De l’application external) dans la barre de menu en haut lorsque votre application est activé, s’il vous plait ?
Ou ajouter une option pour faire cela.

Merci,

Hello, Thanks for your application. Can you add the ability to add the external web icon to the top menu please, when your application is activated, please ? Or add an option for that. Thanks, Bonjour, Merci pour l'application. Serait ce possible d'avoir les icones des sites web externe (De l'application external) dans la barre de menu en haut lorsque votre application est activé, s'il vous plait ? Ou ajouter une option pour faire cela. Merci,
deblan added the
enhancement
label 5 months ago
deblan closed this issue 5 months ago
deblan commented 5 months ago
Owner

Fixed in the next release but it’s an experimental feature.

Fixed in the next release but it's an experimental feature.
Ludovicis commented 5 months ago
Poster

Hello Deblan,

first of all, thanks for this addition
I have test this new experimental feature.
It’s OK on web desktop navigator chrome and firefox (all the icons appear and not a few, like the behavior of nextcloud without your application).

But it’s not OK with mobile navigator (Chrome mobile), the icons of external websites remove the menus at the top right (Settings, applications ...) because all the icons appear and not a few, like the behavior of nextcloud without your application.

Thanks,

Hello Deblan, first of all, thanks for this addition I have test this new experimental feature. It's OK on web desktop navigator chrome and firefox (all the icons appear and not a few, like the behavior of nextcloud without your application). But it's not OK with mobile navigator (Chrome mobile), the icons of external websites remove the menus at the top right (Settings, applications ...) because all the icons appear and not a few, like the behavior of nextcloud without your application. Thanks,
deblan reopened this issue 5 months ago
deblan commented 5 months ago
Owner

Can you test the version v1.6.1 please?

Can you test the version v1.6.1 please?
Ludovicis commented 5 months ago
Poster

Hello,

Display on mobile browser on firefox and chrome on ios is now OK. But now no menu is functional in nextcloud, neither the file manager nor the parameters at the top right; nothing at all (Always from the mobile).

Hello, Display on mobile browser on firefox and chrome on ios is now OK. But now no menu is functional in nextcloud, neither the file manager nor the parameters at the top right; nothing at all (Always from the mobile).
deblan commented 5 months ago
Owner

I tried opera mobile, firefox mobile and chrome mobile: the side menu and the parameters are functional. The file manager does not show the files with opera mobile (with and without side_menu). The search engine of the files takes a place and the right menu is cut (Samsung S8).

I tried opera mobile, firefox mobile and chrome mobile: the side menu and the parameters are functional. The file manager does not show the files with opera mobile (with and without side_menu). The search engine of the files takes a place and the right menu is cut (Samsung S8).
Ludovicis commented 5 months ago
Poster

After a second test, i confirm my problem. Same problem on safari web mobile navigator, the place of the right menu is no cut on Ios.
I have Nextcloud 18.0.4, ios 13.3.1 Iphone 7

After a second test, i confirm my problem. Same problem on safari web mobile navigator, the place of the right menu is no cut on Ios. I have Nextcloud 18.0.4, ios 13.3.1 Iphone 7
deblan commented 5 months ago
Owner

On IOS 13.4.1, the app works on Safari. I can’t reproduce your problem.

On IOS 13.4.1, the app works on Safari. I can't reproduce your problem.
deblan added the
help wanted
label 5 months ago
Ludovicis commented 5 months ago
Poster

Yes on IOS 13.4.1 the app works on Safari, Chrome and Firefox. Display is alway OK.
but not completely, the nextcloud app, the top right menu is OK. But i can’t open web external link in top menu.
it flashes and nothing happens

Yes on IOS 13.4.1 the app works on Safari, Chrome and Firefox. Display is alway OK. but not completely, the nextcloud app, the top right menu is OK. But i can't open web external link in top menu. it flashes and nothing happens
deblan commented 5 months ago
Owner

Can you replace side_menu/templates/js/script.php with 9a8f5517b6/templates/js/script.php please?
This contains the last referenced commit that apply a kind of cache to limit flashes.

Can you replace `side_menu/templates/js/script.php` with https://gitnet.fr/deblan/side_menu/raw/commit/9a8f5517b6003abf0663a650f0f75dfb29c323d8/templates/js/script.php please? This contains the last referenced commit that apply a kind of cache to limit flashes.
Ludovicis commented 5 months ago
Poster

Hello,
With your new script.php file all is good now.
No more problem on Ios Mobile with Firefox, Chrome, Safari and desktop navigator.
All is perfect.
Thanks again,

Hello, With your new script.php file all is good now. No more problem on Ios Mobile with Firefox, Chrome, Safari and desktop navigator. All is perfect. Thanks again,
deblan commented 5 months ago
Owner

Fixed in v1.6.2 👍

Fixed in v1.6.2 :+1:
deblan closed this issue 5 months ago
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.