deblan/side_menu

Fork 5

[BUG] Unknown call to setInterval #66

New issue

Closed

opened 2021-10-28 00:08:01 +02:00 by Some-Twilight-Sparkle · 3 comments

Some-Twilight-Sparkle commented

2021-10-28 00:08:01 +02:00

Issue

Environment

Custom menu version: 1.28.0
Nextcloud version: 21.0.5
PHP version: 7.4.25

The Stuff

Every 50ms this is triggered:

Offending trigger line:

setInterval(updateTopMenu, 50)

Offending function line:

var updateTopMenu = function() {

I've no clue why this line or function exists.
IMO, there shouldn't be such a call. Unneccessary for a menu and way too often. It essentially makes the app unusable.

Additionally, I was able to kill the interval and everything works fine without it.

My Question: Why does such a call exist without any reference or reason? I'm unable to identify a issue or clear commit for this.
(But apperantly it has smth. to do with #19, but I don't see why a endless running setInterval (every 50ms!!) is neccessary.)

LG,

random user who recommends using a more public repository like gitHub, gitLab or BitBucket. Selfhosted instances aren't very suitable for collaboration nor friendly for reporting issues.

PS: Thanks to this, I now know I can safely have over 100k warnings in one tab :p

## Issue ### Environment * Custom menu version: 1.28.0 * Nextcloud version: 21.0.5 * PHP version: 7.4.25 ### The Stuff Every 50ms this is triggered: ![image](/attachments/16ef7152-8cc0-4711-a2ed-8b71f0f9df6a) Offending trigger line: https://gitnet.fr/deblan/side_menu/src/commit/cc71fda3b01e73ae907bdc136c051ff024746112/templates/js/_topMenuApps.js#L172 Offending function line: https://gitnet.fr/deblan/side_menu/src/commit/cc71fda3b01e73ae907bdc136c051ff024746112/templates/js/_topMenuApps.js#L3 I've no clue why this line or function exists. IMO, there shouldn't be such a call. Unneccessary for a menu and way too often. It essentially makes the app unusable. Additionally, I was able to kill the interval and everything works fine without it. My Question: Why does such a call exist without any reference or reason? I'm unable to identify a issue or clear commit for this. (But apperantly it has smth. to do with #19, but I don't see why a endless running setInterval (every 50ms!!) is neccessary.) ----- LG, random user who recommends using a more public repository like gitHub, gitLab or BitBucket. Selfhosted instances aren't very suitable for collaboration nor friendly for reporting issues. PS: Thanks to this, I now know I can safely have over 100k warnings in one tab :p

Some-Twilight-Sparkle added the

bug

label 2021-10-28 00:08:01 +02:00

deblan added the

WIP

label 2021-10-29 11:28:17 +02:00

deblan added a new dependency 2021-10-29 11:28:35 +02:00

#67 Don't use jQuerry anymore

deblan referenced this issue from a commit

2021-10-29 13:56:52 +02:00

fix top menu generation; fix issue #66 by removing usage of setInterval

deblan commented

2021-10-29 14:11:05 +02:00

Owner

Should be fixed in the jquery refactoring branch.

Reporting an issue on Github, gitLab or BitBucket is the same thing than reporting an issue on a forge like Gitnet: you must have an account, login and report.
Doing a pull request on Github, gitLab or BitBucket is the same thing than doing a pull request on a forge like Gitnet: you must have an account, login and do pull request.

...and you can login on Gitnet with a Github or Gitlab account so nothing more complicated or boring :)

Should be fixed in the jquery refactoring branch. ----- Reporting an issue on Github, gitLab or BitBucket is the same thing than reporting an issue on a forge like Gitnet: you must have an account, login and report. Doing a pull request on Github, gitLab or BitBucket is the same thing than doing a pull request on a forge like Gitnet: you must have an account, login and do pull request. ...and you can login on Gitnet with a Github or Gitlab account so nothing more complicated or boring :)

Some-Twilight-Sparkle commented

2021-11-05 16:18:19 +01:00

Author

Should be fixed in the jquery refactoring branch.

👍

You're not wrong. However, I believe it's better to have all modules/additional repos of a project hosted on the same platform as the original one (→ Nextcloud), which is GitHub… (I'm not a fan of it either.)

Or at least having a mirror project for issues only.
Welp, anyway. As you see, I've created an account after all ;)

…mmh, should have tried logging in with GitLab. Wasn't an option on the registration page and hence, I thought, it's only available afterward. (and/or for organization use with auto-acc-creation).

> Should be fixed in the jquery refactoring branch. 👍 ----- You're not wrong. However, I believe it's better to have all modules/additional repos of a project hosted on the same platform as the original one (→ Nextcloud), which is GitHub… (I'm not a fan of it either.) Or at least having a mirror project for issues only. Welp, anyway. As you see, I've created an account after all ;) …mmh, should have tried logging in with GitLab. Wasn't an option on the registration page and hence, I thought, it's only available afterward. (and/or for organization use with auto-acc-creation).

deblan commented

2021-11-14 17:47:20 +01:00

Owner

Released in v2.0.0!

deblan closed this issue

2021-11-14 17:48:40 +01:00