deblan/woodpecker-email
deblan/woodpecker-email
1
0
Fork 1
Code Issues 1 Pull requests 2 Projects Releases Packages 1 Wiki Activity

Inline CSS styles, so mailers can display the mail properly #15

Merged
deblan merged 2 commits from smainz/woodpecker-email:bugfix/issue13-inline-css-styles into develop 2025-03-02 16:12:00 +01:00
Conversation 3 Commits 2 Files changed 3 +7 -1
smainz commented 2025-03-01 15:55:57 +01:00
Contributor
Copy link

Uses symfony css inliner: https://symfony.com/doc/current/mailer.html#inlining-css-styles

I do not think one should add a flag to inline styles or not, as many mailers do not display non-inlined styles properly.

Tested and it works for outlook classic (really picky)

fixes #13

Uses symfony css inliner: https://symfony.com/doc/current/mailer.html#inlining-css-styles I do not think one should add a flag to inline styles or not, as many mailers do not display non-inlined styles properly. Tested and it works for outlook classic (really picky) fixes #13
Inline CSS styles, so mailers can display the mail properly
Some checks are pending
ci/woodpecker/pr/woodpecker Pipeline is pending approval
Details
ci/woodpecker/pull_request_closed/woodpecker Pipeline was successful
Details
486e9c13d6 
Uses symfony css inliner: https://symfony.com/doc/current/mailer.html#inlining-css-styles
deblan requested changes 2025-03-02 10:07:52 +01:00
Dismissed
composer.json
@ -9,2 +9,3 @@
"twig/twig": "^3.8",
"symfony/google-mailer": "^7.1"
"symfony/google-mailer": "^7.1",
"symfony/process": "^7.2",
deblan commented 2025-03-02 10:07:32 +01:00
Owner
Copy link

symfony/process is not necessary. You can remove it.

`symfony/process` is not necessary. You can remove it.
smainz commented 2025-03-02 11:45:34 +01:00
Author
Contributor
Copy link

Done.

Done.
deblan marked this conversation as resolved
Remove symfony/process from dependencies
Some checks are pending
ci/woodpecker/pr/woodpecker Pipeline is pending approval
Details
ci/woodpecker/pull_request_closed/woodpecker Pipeline was successful
Details
7360be6207
deblan commented 2025-03-02 16:11:13 +01:00
Owner
Copy link

Thanks!

Thanks!
deblan approved these changes 2025-03-02 16:11:32 +01:00
deblan merged commit 909fc3de7f into develop 2025-03-02 16:12:00 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
deblan
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
reproduced

   
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
reproduced
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
deblan/woodpecker-email!15
No description provided.